Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libs: Add export of fields #883

Merged
merged 1 commit into from
May 22, 2024
Merged

Libs: Add export of fields #883

merged 1 commit into from
May 22, 2024

Conversation

Angi-Kinas
Copy link
Collaborator

Description

This PR adds a missing export of fields in order for it to be usable as gn-ui package in another project.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented May 22, 2024

Affected libs: feature-search, feature-router, feature-map, feature-dataviz, feature-record,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

📷 Screenshots are here!

@coveralls
Copy link

Coverage Status

coverage: 84.803% (+0.4%) from 84.424%
when pulling 1e52fc7 on add-export-fields
into a26c0b8 on main.

@Angi-Kinas Angi-Kinas merged commit 6b7e19c into main May 22, 2024
9 checks passed
@Angi-Kinas Angi-Kinas deleted the add-export-fields branch May 22, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants