Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: use the complete symbols font locally #879

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented May 21, 2024

This is a followup of #857

The local font used to be otf and not contain every symbol in every variation (fill, outlined); this is fixed with this PR.

Before:
image

After:
image

@jahow
Copy link
Collaborator Author

jahow commented May 21, 2024

@f-necas I can't remember why we let than one slip through; let me know if you see anything that I don't, thanks :)

Copy link
Contributor

Affected libs: , Affected apps: ,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@jahow jahow added this to the 2.3.0 milestone May 21, 2024
Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jahow !

@jahow jahow merged commit 639c48f into main May 27, 2024
7 checks passed
@jahow jahow deleted the restore-outlined-icons branch May 27, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants