Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGN - Organization Page #877

Merged
merged 10 commits into from
Jun 19, 2024
Merged

IGN - Organization Page #877

merged 10 commits into from
Jun 19, 2024

Conversation

rcaplier
Copy link
Collaborator

@rcaplier rcaplier commented May 16, 2024

Description

This PR add a new Organization page.

### BREAKING CHANGES : I wanted to fix the typo : organisation -> organization. I shouldn't have maybe idk. But it may break things in the router. Be careful when rebasing forked repos.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by IGN.

@rcaplier rcaplier self-assigned this May 16, 2024
@rcaplier rcaplier marked this pull request as draft May 16, 2024 15:43
Copy link
Contributor

github-actions bot commented May 16, 2024

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, feature-auth, common-domain, api-metadata-converter, ui-search, common-fixtures, util-shared, ui-elements, feature-notifications, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz, data-access-gn4,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented May 16, 2024

📷 Screenshots are here!

@jahow
Copy link
Collaborator

jahow commented May 17, 2024

Implements #772

@fgravin fgravin linked an issue May 17, 2024 that may be closed by this pull request
@rcaplier rcaplier force-pushed the dh-organization-page branch 2 times, most recently from cf6c0c2 to aee0132 Compare May 24, 2024 14:32
@rcaplier rcaplier force-pushed the dh-organization-page branch 4 times, most recently from ad0c763 to d69d487 Compare June 14, 2024 07:13
@rcaplier rcaplier marked this pull request as ready for review June 14, 2024 07:23
@rcaplier rcaplier force-pushed the dh-organization-page branch 7 times, most recently from eca730f to 9e808d4 Compare June 14, 2024 09:27
@rcaplier rcaplier force-pushed the dh-organization-page branch 2 times, most recently from ee8ebf8 to c692d1c Compare June 14, 2024 10:44
@coveralls
Copy link

Coverage Status

coverage: 83.351% (-0.6%) from 83.98%
when pulling c692d1c on dh-organization-page
into 573bccd on main.

Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work here ! I have left comments about vars names, leftover comments, and suggestions to improve the subscriptions, styling and fallbacks.

Also, some issues I found while testing :

  1. The mailing button doesn't work. When clicking on it, nothing happens - I have added a comment on the button's code because it's missing the target=blank.
  2. Add a fallback in case there is no email. For instance, the MEL org doesn't have an email (actually, a lot of the orgs don't so it might be worth checking if there isn't another source in the metadata for that where they might be?).
  3. As mentioned in the concerned component, if the user decides to look for a specific organization through the URL, there is no fallback page. Use the same fallback as "record not found". Here I tried with : http://localhost:4200/organization/1234

image

@rcaplier rcaplier force-pushed the dh-organization-page branch from c692d1c to 8f91bdb Compare June 18, 2024 05:48
@coveralls
Copy link

Coverage Status

coverage: 83.442% (+0.1%) from 83.298%
when pulling 8f91bdb on dh-organization-page
into e1bb65c on main.

@rcaplier rcaplier force-pushed the dh-organization-page branch 2 times, most recently from a1ac3ff to 10aa2d3 Compare June 18, 2024 06:36
@coveralls
Copy link

Coverage Status

coverage: 83.383% (+0.09%) from 83.298%
when pulling 10aa2d3 on dh-organization-page
into e1bb65c on main.

@rcaplier rcaplier force-pushed the dh-organization-page branch from 10aa2d3 to b60d11f Compare June 18, 2024 07:15
@coveralls
Copy link

Coverage Status

coverage: 83.383% (+0.09%) from 83.298%
when pulling b60d11f on dh-organization-page
into e1bb65c on main.

@rcaplier rcaplier force-pushed the dh-organization-page branch from b60d11f to 48e0ce8 Compare June 18, 2024 09:21
@coveralls
Copy link

Coverage Status

coverage: 83.382% (+0.08%) from 83.298%
when pulling 48e0ce8 on dh-organization-page
into e1bb65c on main.

@rcaplier rcaplier force-pushed the dh-organization-page branch from 48e0ce8 to 756270f Compare June 18, 2024 12:33
@coveralls
Copy link

Coverage Status

coverage: 83.382% (-0.6%) from 84.008%
when pulling 756270f on dh-organization-page
into 9c5250e on main.

@jahow jahow added the breaking change Requires an adaptation by the user to keep feature parity label Jun 18, 2024
Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rework!
It looks better already 🙂

I just have noticed one behavior I mentioned in my last review that you might have missed that I'm copy pasting here :

"Add a fallback in case there is no email. For instance, the MEL org doesn't have an email (actually, a lot of the orgs don't so it might be worth checking if there isn't another source in the metadata where they might be?)." --> I think we should at least make the button disabled or something if the email is not available, it makes more sense user-wise.

Also, for you next PRs, it might be nice to keep the history of your commits instead of force-pushing on the same commit after a review has been done, it's easier for the reviewer to follow the changes made, IMO 😄

@rcaplier rcaplier force-pushed the dh-organization-page branch from 756270f to 02f2ac2 Compare June 19, 2024 07:53
@rcaplier rcaplier force-pushed the dh-organization-page branch from 02f2ac2 to 27816fd Compare June 19, 2024 07:54
@coveralls
Copy link

Coverage Status

coverage: 83.381% (-0.6%) from 84.008%
when pulling 27816fd on dh-organization-page
into 9c5250e on main.

Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the last fix, LGTM 😃

@rcaplier rcaplier merged commit 27089d8 into main Jun 19, 2024
9 checks passed
@rcaplier rcaplier deleted the dh-organization-page branch June 19, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Requires an adaptation by the user to keep feature parity major feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datahub] Organization Page
4 participants