Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document feature and requirements (esp. for GN versions <4.2.6) #869

Merged
merged 2 commits into from
May 6, 2024
Merged

Document feature and requirements (esp. for GN versions <4.2.6) #869

merged 2 commits into from
May 6, 2024

Conversation

rcaplier
Copy link
Collaborator

Description

This PR add documentation concerning userfeedback section.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

**This work is sponsored by IGN.

@rcaplier rcaplier added the documentation Improvements or additions to documentation label Apr 29, 2024
@rcaplier rcaplier self-assigned this Apr 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited
Loading

Affected libs: , Affected apps: ,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@rcaplier rcaplier force-pushed the dh-userfeedbacks-doc branch from 6ce93bb to 6c98226 Compare April 29, 2024 14:10
jahow
jahow approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rcaplier for documenting this! I reworded/moved the doc to make it easier to discover.

@jahow jahow merged commit e03215d into main May 6, 2024
7 checks passed
@jahow jahow deleted the dh-userfeedbacks-doc branch May 6, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees

@rcaplier rcaplier

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcaplier @jahow