Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me/record field update frequency #868

Merged
merged 6 commits into from
May 23, 2024

Conversation

LHBruneton-C2C
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C commented Apr 26, 2024

Description

This PR introduces support of the update frequency field in the record form.

The dropdown selector can now be disabled.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Apr 26, 2024

Affected libs: api-metadata-converter, feature-editor, feature-search, feature-router, feature-map, feature-dataviz, feature-record, api-repository, feature-catalog, feature-auth, ui-search, ui-inputs, ui-elements, feature-notifications, ui-catalog, ui-layout,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Apr 26, 2024

📷 Screenshots are here!

@LHBruneton-C2C LHBruneton-C2C force-pushed the ME/record-field-update-frequency branch 2 times, most recently from a251c8e to 9c46cf6 Compare April 29, 2024 12:18
@LHBruneton-C2C LHBruneton-C2C marked this pull request as ready for review April 29, 2024 12:20
@LHBruneton-C2C LHBruneton-C2C requested a review from jahow April 29, 2024 12:20
@coveralls
Copy link

coveralls commented Apr 29, 2024

Coverage Status

coverage: 83.1% (-0.1%) from 83.23%
when pulling 15b62fc on ME/record-field-update-frequency
into 8918855 on main.

@LHBruneton-C2C LHBruneton-C2C force-pushed the ME/record-field-update-frequency branch from 9c46cf6 to f93c34b Compare May 2, 2024 09:23
@LHBruneton-C2C
Copy link
Collaborator Author

@jahow Unless we can save floats as duration in ISO format, I don't see how to solve the "3 times a week" => "every 2 days" => "4 times a week" issue (see last wip commit).

@jahow jahow force-pushed the ME/record-field-update-frequency branch from ce3ecaf to 15b62fc Compare May 21, 2024 09:39
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @LHBruneton-C2C , great work and easy review ;)

I've rewritten the last commit to make the converter stable when doing back and on forth on the update frequency field for frequencies higher than one week. Let me know if that makes sense to you! feel free to merge when ready.

@LHBruneton-C2C
Copy link
Collaborator Author

Thanks @jahow for the last commit!

@LHBruneton-C2C LHBruneton-C2C merged commit 8224939 into main May 23, 2024
9 checks passed
@LHBruneton-C2C LHBruneton-C2C deleted the ME/record-field-update-frequency branch May 23, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants