-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support to run pipeline registration in secured ES clusters #867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that makes a lot of sense! I suggested a small improvement because there's already a native function for converting to base64 (atob
). Also could you please leave a note in the docs about this option? e.g. at the end of this chapter https://github.com/geonetwork/geonetwork-ui/blob/main/docs/guide/deploy.md#option-a-executing-a-node-script
Thank you!!
PS: I've tested without authentication on the default docker composition and the empty Auth header does not cause any issue. |
Co-authored-by: Olivia Guyot <[email protected]>
Co-authored-by: Olivia Guyot <[email protected]>
thanks, i was mostly having concerns about potential weird mitm 'secure' proxies that might exist in cloud environments and choke on that... as for atob, i had seen it on stackoverflow but i wasn't sure if it was part of the standard library - thanks for confirming. |
ah, now i know why i didn't use |
and now i've figured out why
edit to be able to remove a pipeline, first it should be removed from the index settings via a |
Ah right, that makes sense. I wouldn't worry too much about this to be honest, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@landryb I've added a commit to the branch because the formatting was failing, other than that this is good to merge! thanks!
i might be a paranoid but my ES clusters have security on and require authentication, so this is required to deploy https://geonetwork.github.io/geonetwork-ui/main/docs/guide/deploy.html#enabling-improved-search-fields
i know this might be ugly, and 'better' to take username/password from env vars .. feedback welcome.
also i failed to run
npm run lint
(because i haven't done a full build of the repo) so i suppose wrapping is wrong.with that diff i'm able to register the pipeline and set it as the default one for a custom gn-records index.
afaict for non-securised ES clusters, sending an empty
Authorization:
header doesnt seem to bother ES which replies anyway. I can make it conditional toauthHeader
being non-empty but i don't know the syntax of modern javascript to do that.clear
doesn't seem to work, because running it afterregister
just says No geonetwork-ui pipelines found, exitingcc @fgravin @jahow @f-necas for opinions