Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me/record field resource updated #866

Merged
merged 5 commits into from
May 2, 2024

Conversation

LHBruneton-C2C
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C commented Apr 26, 2024

Description

This PR introduces support of the resource updated field in the record form.

A new date-picker input component has been added.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@LHBruneton-C2C LHBruneton-C2C requested a review from jahow April 26, 2024 08:37
Copy link
Contributor

github-actions bot commented Apr 26, 2024

Affected libs: common-fixtures, api-metadata-converter, feature-editor, api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, ui-search, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Apr 26, 2024

📷 Screenshots are here!

.nvmrc Outdated
@@ -0,0 +1 @@
18.16.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: clean

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

In storybook the datepicker overlay doesn't show when clicking the icon, this is the error showing up:
image

@LHBruneton-C2C LHBruneton-C2C force-pushed the ME/record-field-resource-updated branch from 1c8e1ef to 7433830 Compare April 30, 2024 15:07
@LHBruneton-C2C LHBruneton-C2C force-pushed the ME/record-field-resource-updated branch from 7433830 to d803315 Compare May 2, 2024 07:15
@coveralls
Copy link

coveralls commented May 2, 2024

Coverage Status

coverage: 83.416% (+1.7%) from 81.762%
when pulling bd1ee94 on ME/record-field-resource-updated
into e07c560 on main.

@LHBruneton-C2C LHBruneton-C2C merged commit f54cc11 into main May 2, 2024
9 checks passed
@LHBruneton-C2C LHBruneton-C2C deleted the ME/record-field-resource-updated branch May 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants