Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datahub]: add comment and discussion module to record page #849

Merged
merged 9 commits into from
Apr 29, 2024
Merged

[Datahub]: add comment and discussion module to record page #849

merged 9 commits into from
Apr 29, 2024

Conversation

rcaplier
Copy link
Collaborator

@rcaplier rcaplier commented Apr 10, 2024 •
edited
Loading

Description

This PR introduces add the comment and discussion module to the record page.

Changes description

I had to change some things in the lib ui to fit the mockups :

  • added the possibility to override css classes in the gn-ui-text-input and gn-ui-text-area component as it is already done for the gn-ui-button component

@rcaplier rcaplier self-assigned this Apr 10, 2024
@rcaplier rcaplier marked this pull request as draft April 10, 2024 09:13
@rcaplier rcaplier force-pushed the dh-add-comment-and-discussion-module-to-record-page branch from ef76e50 to 7899bfe Compare April 10, 2024 09:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

📷 Screenshots are here!

@rcaplier rcaplier force-pushed the dh-add-comment-and-discussion-module-to-record-page branch from 7899bfe to 9245dee Compare April 10, 2024 09:17
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, common-domain, api-metadata-converter, feature-editor, ui-search, common-fixtures, util-shared, ui-elements, feature-notifications, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz, data-access-datafeeder, util-data-fetcher, util-app-config, data-access-gn4, util-i18n,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@rcaplier rcaplier force-pushed the dh-add-comment-and-discussion-module-to-record-page branch 10 times, most recently from 0fa7b34 to b1b724f Compare April 15, 2024 11:10
jahow
jahow reviewed Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, it's looking really good so far!

libs/ui/inputs/src/lib/text-area/text-area.component.ts Outdated Show resolved Hide resolved
support-services/.env Outdated Show resolved Hide resolved
libs/ui/elements/src/lib/user-feedback-item/time-since.pipe.ts Show resolved Hide resolved
apps/datahub/src/app/record/record-user-feedbacks/record-user-feedbacks.service.ts Outdated Show resolved Hide resolved
apps/datahub/src/app/record/record-user-feedbacks/record-user-feedbacks.service.ts Outdated Show resolved Hide resolved
apps/datahub/src/app/record/record-user-feedbacks/record-user-feedbacks.service.ts Outdated Show resolved Hide resolved
@rcaplier rcaplier force-pushed the dh-add-comment-and-discussion-module-to-record-page branch 10 times, most recently from 89651cf to 80f08e4 Compare April 22, 2024 07:59
feat: add comment and discussion module to record page
46d269a 
feat: add comment and discussion module to record page

css

ajouts
@rcaplier rcaplier force-pushed the dh-add-comment-and-discussion-module-to-record-page branch from 80f08e4 to 46d269a Compare April 22, 2024 13:11
jahow added 4 commits April 22, 2024 15:56
@jahow
chore: fix dump to have e2e pass
cadd11c 
- add 2 user feedbacks and 1 answer on accroches-velo dataset
- add a SMTP host in the server settings to avoid errors on the user feedback API
@jahow
chore: remove only in e2e test
11d9a90
@jahow
chore: prettier
2efbaec
@jahow
chore: linting
84d514a
@jahow jahow marked this pull request as ready for review April 22, 2024 14:04
@rcaplier rcaplier force-pushed the dh-add-comment-and-discussion-module-to-record-page branch from 87d4fcf to 4017236 Compare April 24, 2024 09:32
@rcaplier rcaplier force-pushed the dh-add-comment-and-discussion-module-to-record-page branch from 4017236 to 651d488 Compare April 24, 2024 09:53
@coveralls
Copy link

coveralls commented Apr 24, 2024 •
edited
Loading

Coverage Status

coverage: 84.078% (-0.04%) from 84.119%
when pulling 9c2c9e7 on dh-add-comment-and-discussion-module-to-record-page
into 139106e on main.

cmoinier
cmoinier requested changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, very well done on your first PR @rcaplier 🎉
It's a really good work. I have left some comments, most of them are about missing unit tests, languages and e2e improvement. Let me know if you have any questions 😃

apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts Outdated Show resolved Hide resolved
apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts Outdated Show resolved Hide resolved
apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts Outdated Show resolved Hide resolved
apps/datahub/src/app/record/record-metadata/record-metadata.component.html Show resolved Hide resolved
apps/datahub/src/app/record/record-user-feedbacks/record-user-feedbacks.component.html Outdated Show resolved Hide resolved
libs/api/repository/src/lib/gn4/platform/gn4-platform.mapper.ts Show resolved Hide resolved
libs/common/fixtures/src/lib/records.fixtures.ts Show resolved Hide resolved
libs/feature/record/src/lib/state/mdview.facade.spec.ts Show resolved Hide resolved
libs/ui/elements/src/lib/user-feedback-item/user-feedback-item.component.html Show resolved Hide resolved
libs/ui/elements/src/lib/user-feedback-item/user-feedback-item.component.html Outdated Show resolved Hide resolved
@rcaplier rcaplier force-pushed the dh-add-comment-and-discussion-module-to-record-page branch from 2a74b0e to dd46dc9 Compare April 29, 2024 07:17
@rcaplier rcaplier force-pushed the dh-add-comment-and-discussion-module-to-record-page branch from dd46dc9 to 9c2c9e7 Compare April 29, 2024 12:16
cmoinier
cmoinier approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rework @rcaplier, well done ! 😃

@rcaplier rcaplier merged commit 3efe236 into main Apr 29, 2024
9 checks passed
@cmoinier cmoinier deleted the dh-add-comment-and-discussion-module-to-record-page branch April 30, 2024 06:51
@jahow jahow mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow left review comments

@cmoinier cmoinier cmoinier approved these changes

Assignees

@rcaplier rcaplier

Labels
minor feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rcaplier @coveralls @jahow @cmoinier