Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Remove warning from console if filter geometry undefined #798

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Feb 19, 2024

Description

This PR prevents displaying a warning in the console if no filter_geometry could be found (which is already logged in the console). This might occur when a request to the geometry aborts without success (due to access rights or a wrong url for example).

image-2024-02-15-08-47-08-973

Follow-up on #635

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@tkohr tkohr changed the title Datahub: Do not check geojson validity if geom undefined Datahub: Remove warning from console if filter geometry undefined Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Affected libs: feature-search, feature-router, feature-map, feature-dataviz, feature-record,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Feb 19, 2024

Coverage Status

coverage: 86.054% (+2.1%) from 83.944%
when pulling 696ca82 on no-geom-no-error
into ca02804 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made a few comments, also I think your idea about always returning null is good. In general the fix looks good so I'm approving, I hope the tests will eventually turn green...

libs/feature/search/src/lib/state/effects.ts Outdated Show resolved Hide resolved
libs/feature/search/src/lib/state/effects.ts Show resolved Hide resolved
libs/feature/search/src/lib/state/effects.spec.ts Outdated Show resolved Hide resolved
@tkohr tkohr merged commit ae0a63a into main Feb 21, 2024
10 checks passed
@tkohr tkohr deleted the no-geom-no-error branch February 21, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants