Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybooj][Fix] : Add accessServiceProtocol to link fixture #740

Merged
merged 1 commit into from
Dec 22, 2023
Merged

[Storybooj][Fix] : Add accessServiceProtocol to link fixture #740

merged 1 commit into from
Dec 22, 2023

Conversation

cmoinier
Copy link
Collaborator

Adding missing property for ogcApiFormat element in link fixtures.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2023 •
edited by tkohr
Loading

Affected libs: common-fixtures, api-metadata-converter, feature-editor, feature-search, feature-router, feature-map, feature-dataviz, feature-record, api-repository, feature-catalog, feature-auth, ui-search, ui-elements, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-map,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 83.096% (+0.03%) from 83.069%
when pulling b2600e3 on DH/fix-storybook
into 80787c2 on main.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2023 •
edited
Loading

GitHub Pages links:

  • (Documentation)[https://geonetwork.github.io/geonetwork-ui/DH/fix-storybook/docs/]
  • (Demo & web components)[https://geonetwork.github.io/geonetwork-ui/DH/fix-storybook/demo/]
  • (UI components storybook)[https://geonetwork.github.io/geonetwork-ui/DH/fix-storybook/storybook/demo/]

tkohr
tkohr approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @cmoinier!

@cmoinier cmoinier merged commit ab94f4f into main Dec 22, 2023
7 checks passed
@cmoinier cmoinier deleted the DH/fix-storybook branch December 22, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkohr tkohr tkohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmoinier @coveralls @tkohr