Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Propose external viewer button for geojson files #736

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Dec 19, 2023

The PR proposes the external viewer button for geojson files as seen on the screenshot.

Can be tested on http://localhost:4200/dataset/accroche_velos with the following config:

geonetwork4_api_url = "https://mel.integration.apps.gs-fr-prod.camptocamp.com/geonetwork/srv/api"
proxy_path = "/dev-proxy?"
external_viewer_url_template = 'https://mel.integration.apps.gs-fr-prod.camptocamp.com/mapstore/#/?actions=[{"type":"CATALOG:ADD_LAYERS_FROM_CATALOGS","layers":["${layer_name}"],"sources":[{"url":"${service_url}","type":"${service_type}"}]}]'

Note that the deployed mapstore version needs to support this feature and the link url indicated in the metadata for the geojson file needs to allow CORS requests.

external_geojson

Copy link
Contributor

Affected libs: feature-record, feature-router, util-app-config, feature-map, feature-dataviz,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 86.302% (+4.4%) from 81.942%
when pulling 387b474 on external-geojson
into 19be416 on main.

@fgravin fgravin added this to the 2.1.0 milestone Dec 19, 2023
Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for adding those tests.
I've tested it and it works well !

@fgravin fgravin merged commit f49cddd into main Dec 19, 2023
8 checks passed
@fgravin fgravin deleted the external-geojson branch December 19, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants