Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map context: fix WMTS layer extent #735

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Map context: fix WMTS layer extent #735

merged 3 commits into from
Dec 20, 2023

Conversation

fgravin
Copy link
Member

@fgravin fgravin commented Dec 19, 2023

A the moment, the extent used to zoom on a WMTS layer is the tilegrid extent, extracted by Openlayers from the getCapabilities informations. It's generally the projection world extent.

The idea is to get the accurate extent of the layer from the capabilities itself, and use it if any.

Sponsored by SwissTopo geocat.ch

@fgravin fgravin added the bug Something isn't working label Dec 19, 2023
@fgravin fgravin linked an issue Dec 19, 2023 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Dec 19, 2023

Affected libs: feature-map, feature-dataviz, feature-record, feature-router,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

This fix the zoom to layer option on the map context while loading a WMTS layer
@coveralls
Copy link

Coverage Status

coverage: 85.453% (+3.5%) from 81.942%
when pulling 206676f on fix-extent
into 19be416 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good enough for now, thanks :)

@fgravin fgravin merged commit 95f0151 into main Dec 20, 2023
8 checks passed
@fgravin fgravin deleted the fix-extent branch December 20, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map context: WMTS layers are not centered
3 participants