Reload the application on language switch #681
Merged
+193
−192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multilingual concerns, after that the user switches the language, the application should
The easiest way to achieve all of that is to reload the page for now.
Note: the
language-switcher
is a UI component and should not interact with thelocalStorage
IMO. I didn't want to refactor so I added the reload along the storage process.The PR also modifies the content of the language switcher, to translate the entries from the targeted language.