Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ME: Add checkbox for records table #661

Merged
merged 4 commits into from
Oct 30, 2023
Merged

ME: Add checkbox for records table #661

merged 4 commits into from
Oct 30, 2023

Conversation

Angi-Kinas
Copy link
Collaborator

image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, common-domain, api-metadata-converter, feature-editor, ui-search, common-fixtures, util-shared, ui-elements, ui-catalog, ui-widgets, ui-inputs, ui-map, ui-dataviz, util-app-config,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, map-viewer, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@Angi-Kinas Angi-Kinas force-pushed the ME-checkbox-for-rcords-table branch from 5debba8 to a729ec1 Compare October 24, 2023 15:27
@coveralls
Copy link

Coverage Status

coverage: 81.783% (-4.8%) from 86.546% when pulling a729ec1 on ME-checkbox-for-rcords-table into f8b9e53 on main.

@jahow jahow changed the base branch from main to develop October 25, 2023 09:53
@Angi-Kinas Angi-Kinas force-pushed the ME-checkbox-for-rcords-table branch from a729ec1 to 41fe63b Compare October 25, 2023 12:24
@Angi-Kinas Angi-Kinas mentioned this pull request Oct 25, 2023
Merged
@Angi-Kinas Angi-Kinas force-pushed the ME-checkbox-for-rcords-table branch 2 times, most recently from c474e59 to 13dbb50 Compare October 26, 2023 07:39
jahow
jahow approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! looking good :)

BTW we should add some e2e tests for that but that can be done in #666

@Angi-Kinas Angi-Kinas force-pushed the ME-checkbox-for-rcords-table branch from 13dbb50 to 80c693d Compare October 30, 2023 10:39
@Angi-Kinas Angi-Kinas merged commit 0acb34a into develop Oct 30, 2023
5 checks passed
@Angi-Kinas Angi-Kinas deleted the ME-checkbox-for-rcords-table branch October 30, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Angi-Kinas @coveralls @jahow