Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebComponents / fix dropdown-selector not showing #658

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Oct 20, 2023

This PR brings several fixes to the web components:

  • Rework the logic for providing a custom OverlayContainer in web components, by looking at the first ShadowDOM found and putting the container in it; this will make any custom overlays (e.g. dropdowns) work correctly
  • Use a different event for closing the overlays in the dropdown components
  • Fixes the font URL used for icons
  • Add a logic on web components init to copy all @font-face definitions to the host document; this is necessary because @font-face rules in ShadowDOM will not trigger the download of the font, thus icons will never show in web components without that

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Affected libs: feature-search, feature-router, feature-record, feature-map, feature-dataviz, ui-inputs, feature-editor, ui-elements, feature-catalog, ui-catalog, ui-search,
Affected apps: webcomponents, metadata-editor, datahub, demo, search, map-viewer, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Oct 20, 2023

Coverage Status

coverage: 81.812% (-4.6%) from 86.461% when pulling 6291baa on fix-dropdown-wc into 3c899e0 on main.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the various fixes @jahow !

Just noticed that the dropdown does not close when clicking the select box itself.

…kdrop

This makes the overlay correctly close with WC as well
@jahow jahow added the bug Something isn't working label Oct 23, 2023
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jahow, working very smoothly now!

@jahow jahow merged commit f87f421 into main Oct 24, 2023
5 checks passed
@jahow jahow deleted the fix-dropdown-wc branch October 24, 2023 07:27
@cmoinier cmoinier added this to the 2.0.2 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants