Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CORS issues in webcomponent demo #655

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Fix CORS issues in webcomponent demo #655

merged 2 commits into from
Oct 19, 2023

Conversation

fgravin
Copy link
Member

@fgravin fgravin commented Oct 19, 2023

The web components related to data visualization (table & chart) had CORS issue because of the Data API they used (wrong ODS API with CORS restriction).

So I just changed the dataset to have other API calls without CORS restriction.

I also removed the facet example as it is not working.

@fgravin fgravin added the bug Something isn't working label Oct 19, 2023
@fgravin fgravin added this to the 2.0.1 milestone Oct 19, 2023
@fgravin fgravin requested a review from tkohr October 19, 2023 10:17
@fgravin fgravin linked an issue Oct 19, 2023 that may be closed by this pull request
Demo: dataviz web components have CORS issue #647
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023 •
edited by fgravin
Loading

Affected libs: ``,
Affected apps: webcomponents,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 100.0% (+16.3%) from 83.745% when pulling 999a457 on cors-wc into 2089b7b on main.

@fgravin fgravin linked an issue Oct 19, 2023 that may be closed by this pull request
demo: ensure web component demo are working #648
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023 •
edited
Loading

GitHub Pages links:

  • (Documentation)[https://geonetwork.github.io/geonetwork-ui/cors-wc/docs/]
  • (Demo & web components)[https://geonetwork.github.io/geonetwork-ui/cors-wc/demo/]
  • (UI components storybook)[https://geonetwork.github.io/geonetwork-ui/cors-wc/storybook/demo/]

jahow
jahow approved these changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fgravin fgravin merged commit 96f8590 into main Oct 19, 2023
5 checks passed
@fgravin fgravin deleted the cors-wc branch October 19, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

@tkohr tkohr Awaiting requested review from tkohr

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

demo: ensure web component demo are working Demo: dataviz web components have CORS issue
3 participants
@fgravin @coveralls @jahow