Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datahub / show links and APIs as a carousel #649

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Datahub / show links and APIs as a carousel #649

merged 4 commits into from
Nov 3, 2023

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Oct 13, 2023 •
edited
Loading

This PR adds a gn-ui-carousel component used in the record view of the Datahub:

image

To do:

  • improve appearance in mobile view
  • add tests
  • fix weird scrollbar

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

Affected libs: feature-record, feature-router, ui-layout, feature-dataviz, feature-catalog, ui-elements, feature-search, feature-map, ui-catalog, ui-search, api-metadata-converter, api-repository, feature-auth, feature-editor, data-access-datafeeder, util-data-fetcher, data-access-gn4, util-app-config, common-fixtures, util-shared, ui-widgets, ui-inputs, ui-map, common-domain, ui-dataviz, util-i18n,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

fgravin
fgravin approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent !
Thanks for adding this nice looking features 🤩

@fgravin fgravin added this to the 2.1.0 milestone Oct 18, 2023
@jahow jahow force-pushed the add-carrousel-component branch 2 times, most recently from 414e329 to e52e285 Compare October 20, 2023 09:28
@jahow jahow marked this pull request as ready for review October 20, 2023 09:41
@jahow jahow force-pushed the add-carrousel-component branch 2 times, most recently from 66ec5eb to 5042279 Compare October 20, 2023 11:18
@coveralls
Copy link

coveralls commented Oct 20, 2023 •
edited
Loading

Coverage Status

coverage: 83.796% (+0.7%) from 83.092%
when pulling 54d1b3d on add-carrousel-component
into 2901ae6 on main.

@jahow
Copy link
Collaborator Author

jahow commented Oct 20, 2023

This is ready to merge, waiting for the 2.0.1 with bugfixes to come out

@jahow jahow merged commit 416fe36 into main Nov 3, 2023
7 checks passed
@jahow jahow deleted the add-carrousel-component branch November 3, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgravin fgravin fgravin approved these changes

Assignees
No one assigned
Labels
minor feature
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jahow @coveralls @fgravin