Datahub: Fix thumbnail background for org logos #636
Conversation
this fixes the gray background currently applied to logos
to have cleaner classes
|
Affected libs:
|
| 'bg-white': !isPlaceholder | ||
| }" | ||
| class="h-full w-full relative shrink-0 overflow-hidden flex items-center" | ||
| [ngClass]="isPlaceholder ? 'bg-gray-100' : 'bg-white'" |
There was a problem hiding this comment.
Very good catch here, we basically had no guarantee that bg-white would have priority over bg-gray-100 prior to this change
There was a problem hiding this comment.
The more crucial thing is actually setting the isPlaceholder to false when updateImageList is triggered via ngOnChanges() with a logo, I have the feeling. Not sure if the added tests really cover this well. But yes the html should be cleaner this way, too :-)
There was a problem hiding this comment.
yes indeed, the bg- classes weren't the core problem but they could have become a random and hard to track bug later on.
PR fixes the background color of logos, which is currently gray when loading the datahub on the organisations tab or when turning pages in the orgs tab.