Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub : Custom data toggle broken #619

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Sep 14, 2023

Issue

The custom filter buttons of the home header were broken because of a missing sort argument expected in their properties. However, such a property is not asked in the TOML's instructions. Fixed by getting the current sorting parameter as a sort argument.

To test

Add a custom button to the TOML file, for instance :

`[[search_preset]]
name = 'filterByLicense'
filters.q = 'Full text search'
filters.license = ['unknown']
sort = 'createDate'

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 85.906% (-0.7%) from 86.613% when pulling db74690 on datahub-custom-data-toggle-broken into 0ccb939 on main.

@cmoinier cmoinier requested a review from jahow September 20, 2023 15:32
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cmoinier, works as expected now with and without sort.

(Maybe you could update your example in the PR description ['createDate'] => 'createDate' according to your code.)

@cmoinier cmoinier merged commit a9fd646 into main Sep 21, 2023
7 checks passed
@cmoinier cmoinier deleted the datahub-custom-data-toggle-broken branch September 21, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants