Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata-editor: sorting url #616

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Metadata-editor: sorting url #616

merged 1 commit into from
Sep 12, 2023

Conversation

cmoinier
Copy link
Collaborator

Issue

Adding a sorting parameter to the URL.

Resolution

This was more of a fix than a dev, and took some investigation. Turns out the Search Facade was called instead of the Search Service in record-list-component, preventing the URL from being updated on sorting (including when the catalog is initialized, was not working beforehand).

@cmoinier cmoinier marked this pull request as ready for review September 11, 2023 14:07
@cmoinier cmoinier marked this pull request as draft September 11, 2023 14:07
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Affected libs: feature-search, feature-router, feature-record, feature-map, feature-dataviz,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@cmoinier cmoinier marked this pull request as ready for review September 11, 2023 14:15
@coveralls
Copy link

coveralls commented Sep 11, 2023

Coverage Status

coverage: 86.613% (-0.9%) from 87.558% when pulling 6f6ad83 on ME/sorting-url into db3eae9 on main.

@cmoinier cmoinier requested a review from jahow September 11, 2023 14:22
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! That system is error-prone...

@cmoinier
Copy link
Collaborator Author

cmoinier commented Sep 12, 2023

Looking good, thanks! That system is error-prone...

Thanks @jahow ! However, @Angi-Kinas reported an error on loading the app, that I now reproduce. It seems that the app isn't too happy with the initialization of the catalog with this.searchService.setSortBy(['desc', 'changeDate']) in the constructor, making the URL flicker. I'm looking into it now. Did everything work when you tested? Edit : moving the initialization to OnInit fixed it.

@cmoinier cmoinier merged commit 0ccb939 into main Sep 12, 2023
5 checks passed
@cmoinier cmoinier deleted the ME/sorting-url branch September 12, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants