Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve image loading and displaying in gn-ui thumbnail #540

Merged
merged 6 commits into from
Jul 27, 2023
Merged

feat: improve image loading and displaying in gn-ui thumbnail #540

merged 6 commits into from
Jul 27, 2023

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Jul 25, 2023

  • Using url instead of B64 image
  • Set image loading as lazy
  • Use JS to set image as cover or contain object-fit

@f-necas f-necas requested a review from jahow July 25, 2023 08:24
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023 •
edited
Loading

Affected libs: feature-search, feature-record, feature-router, feature-map, feature-dataviz, ui-catalog, feature-catalog, ui-elements, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@f-necas f-necas marked this pull request as ready for review July 25, 2023 08:28
@f-necas f-necas force-pushed the improving-thumbnail-display branch from 15c86d8 to 3f8b954 Compare July 25, 2023 15:38
@f-necas
fix: improve display
66af17b 
fix: improve display
@f-necas f-necas force-pushed the improving-thumbnail-display branch from 3f8b954 to 66af17b Compare July 25, 2023 15:41
@fgravin fgravin added this to the 1.1.0 milestone Jul 27, 2023
@coveralls
Copy link

coveralls commented Jul 27, 2023 •
edited
Loading

Coverage Status

coverage: 86.886% (+4.0%) from 82.915% when pulling a0dd62f on improving-thumbnail-display into 94252f4 on main.

jahow
jahow approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks! Feel free to merge when there is a unit test for the cover/scale-down logic :)

@f-necas f-necas merged commit c61a8e7 into main Jul 27, 2023
5 checks passed
@jahow jahow deleted the improving-thumbnail-display branch July 27, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@f-necas @coveralls @jahow @fgravin