-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Ignore search value in filter reset button #1065
Conversation
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tkohr this was a good catch!
The code looks good and it also works as expected 🚀
I was only wondering about one thing. Would it maybe make sense to add any
to the FILTER_SUMMARY_IGNORE_LIST
? Then you would not have to introduce any new logic if I understand correctly. I'm fine with how it is, just wanted to understand if this would be a solution as well.
Thanks @Angi-Kinas, really good point ! This is indeed much cleaner 🙂 , didn't even think of it. I've adapted accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tkohr !
It looks much simpler now :) 🚀
Description
Small follow-up PR to #1030 and #1037 to prevent
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label