Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Ignore search value in filter reset button #1065

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Dec 13, 2024

Description

Small follow-up PR to #1030 and #1037 to prevent

  • displaying the filter reset button, when doing a textual search
  • resetting the textual search when clicking the button

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Affected libs: feature-search, feature-router, feature-map, feature-record,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Dec 13, 2024

Coverage Status

coverage: 85.834% (+4.1%) from 81.764%
when pulling dca5437 on me-search-filters-summary-ignore-search
into a63d6d0 on main.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

📷 Screenshots are here!

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tkohr this was a good catch!

The code looks good and it also works as expected 🚀
I was only wondering about one thing. Would it maybe make sense to add any to the FILTER_SUMMARY_IGNORE_LIST? Then you would not have to introduce any new logic if I understand correctly. I'm fine with how it is, just wanted to understand if this would be a solution as well.

@tkohr
Copy link
Collaborator Author

tkohr commented Dec 16, 2024

I was only wondering about one thing. Would it maybe make sense to add any to the FILTER_SUMMARY_IGNORE_LIST? Then you would not have to introduce any new logic if I understand correctly. I'm fine with how it is, just wanted to understand if this would be a solution as well.

Thanks @Angi-Kinas, really good point ! This is indeed much cleaner 🙂 , didn't even think of it. I've adapted accordingly.

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tkohr !

It looks much simpler now :) 🚀

@tkohr tkohr merged commit da5f436 into main Dec 17, 2024
14 checks passed
@tkohr tkohr deleted the me-search-filters-summary-ignore-search branch December 17, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants