Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Extract and remove national/regional toggle #1063

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Angi-Kinas
Copy link
Collaborator

Description

This PR extracts and removes/hides the national/regional toggle.

In order to easily configure if the edit form should contain a national/regional toggle, the toggle was extracted out of the spatial extent field and became its own field.
Most of the logic was kept and just moved.
The approach for the form-field is similar to the form-field-constraints-shortcuts, meaning it does not have a model but a componentName in the config.

Screenshots

This is the current state if the component is hidden:
image

This is how it looks if the component is visible:
image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Affected libs: common-fixtures, api-metadata-converter, api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-editor, feature-auth, ui-search, feature-dataviz, ui-elements, feature-notifications, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-layout, ui-map,
Affected apps: metadata-converter, metadata-editor, datahub, demo, webcomponents, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Dec 12, 2024

📷 Screenshots are here!

@coveralls
Copy link

Coverage Status

coverage: 83.963% (+2.2%) from 81.783%
when pulling 87cff9b on ME-extract-and-remove-nation-regional-toggle
into decc890 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants