-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Technical debt] Migration to ng-icons #1020
Conversation
Affected libs:
|
ff5fd8b
to
843a1fc
Compare
📷 Screenshots are here! |
843a1fc
to
8c4080b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!! very impressive work!! I've tested several pages randomly and couldn't find any issues. I wrote down a few remarks in the code, I feel like this PR highlights very much the need for us to have exclusively standalone components, since importing icons becomes very cumbersome otherwise.
Also I think there's a new mat-icon that snuck in there since the branch was rebased on main :)
I'm looking at the test failures now, it seems like a very deep issue, will report there if I find something
8c4080b
to
4a5326d
Compare
That fixed a weird issue where ogc-client would apply polyfills on the node global scope, making some tests fail
96f5904
to
66c9447
Compare
Description
This PR migrates all apps icons from
mat-icon
tong-icon
(and various fixes found along the way).Notes :
tabler-icons
, which were better suited on some occasions.Architectural changes
Added the
ng-icons
library, as well as "ng-icons/material-icons", "ng-icons/tabler-icons", and "ng-icons/iconoir".Quality Assurance Checklist
breaking change
labelbackport <release branch>
label