Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDITOR - Record field: graphic overview #909

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

rcaplier
Copy link
Collaborator

Description

This PR introduces the graphical overview component. Now editor allows to edit the overview of the metadata.

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

**This work is sponsored by **.

@rcaplier rcaplier self-assigned this Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

Affected libs: feature-editor, ui-inputs, feature-dataviz, feature-record, feature-router, feature-search, feature-map, ui-elements, feature-notifications, feature-catalog, ui-catalog, ui-search, ui-layout,
Affected apps: metadata-editor, datafeeder, demo, metadata-converter, datahub, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@rcaplier rcaplier force-pushed the me-add-graphical-overview-record-field branch 2 times, most recently from 648d4b8 to b41e624 Compare June 26, 2024 12:43
Copy link
Contributor

github-actions bot commented Jun 26, 2024

📷 Screenshots are here!

@rcaplier rcaplier force-pushed the me-add-graphical-overview-record-field branch 3 times, most recently from b3c6e02 to 9b596c5 Compare June 27, 2024 07:08
@coveralls
Copy link

Coverage Status

coverage: 81.288% (-5.8%) from 87.04%
when pulling 9b596c5 on me-add-graphical-overview-record-field
into 49a5852 on main.

@rcaplier rcaplier force-pushed the me-add-graphical-overview-record-field branch from 9b596c5 to 47b30b3 Compare July 2, 2024 07:59
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, not tested.

Although, there is some added complexity which I don't understand.

And here too, the name of the PR should not reference our internal Jira tickets.

@rcaplier rcaplier changed the title [GSGNEDIT-68] - Record field: graphic overview Record field: graphic overview Jul 15, 2024
@rcaplier rcaplier changed the title Record field: graphic overview EDITOR - Record field: graphic overview Jul 15, 2024
@LHBruneton-C2C
Copy link
Collaborator

@rcaplier could you resolve the conflicts on this PR, so we can do a final review before merging? Thanks!

@rcaplier
Copy link
Collaborator Author

@rcaplier could you resolve the conflicts on this PR, so we can do a final review before merging? Thanks!

The final review will come when I will finish it.

Like I said in dailies, I still have to adapt the component regarding the version of geonetwork. I still don't know if I have to hide it disable it. Does this need design @jahow ?

Plus, I have to readd the extractFileNameFormUrl() method since it is indeed needed after all.

But thanks for the reminder

@rcaplier rcaplier force-pushed the me-add-graphical-overview-record-field branch 4 times, most recently from 337dee9 to 3a6c33f Compare July 24, 2024 12:22
@coveralls
Copy link

coveralls commented Jul 24, 2024

Coverage Status

coverage: 81.113% (-1.8%) from 82.903%
when pulling 5d22074 on me-add-graphical-overview-record-field
into 7856573 on main.

@rcaplier rcaplier requested a review from LHBruneton-C2C July 25, 2024 09:22
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it this time. The alternative text is not being saved, not on draft and not on record.
Tell me if you need to have a look on my machine.

@rcaplier rcaplier force-pushed the me-add-graphical-overview-record-field branch 3 times, most recently from 92d639a to 5d22074 Compare July 29, 2024 14:46
@rcaplier rcaplier force-pushed the me-add-graphical-overview-record-field branch 4 times, most recently from 5e3b390 to 08c5483 Compare July 31, 2024 12:26
@rcaplier rcaplier force-pushed the me-add-graphical-overview-record-field branch from 08c5483 to 2a38a00 Compare August 1, 2024 06:43
Copy link
Collaborator

@LHBruneton-C2C LHBruneton-C2C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, working as it should now!

@LHBruneton-C2C LHBruneton-C2C merged commit e079151 into main Aug 9, 2024
11 checks passed
@LHBruneton-C2C LHBruneton-C2C deleted the me-add-graphical-overview-record-field branch August 9, 2024 06:04
@jahow jahow mentioned this pull request Aug 13, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants