fix(metadata-info): handle updateFrequency correctly if not defined

geonetwork · Nov 22, 2023 · 8a7f2df · 8a7f2df
1 parent 9d30a1b
commit 8a7f2df
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.spec.ts
@@ -88,6 +88,22 @@ describe('MetadataInfoComponent', () => {
     })
   })
   describe('updateFrequency', () => {
+    describe('updateFrequency is null', () => {
+      beforeEach(() => {
+        fixture = TestBed.createComponent(MetadataInfoComponent)
+        component = fixture.componentInstance
+        component.metadata = {
+          ...DATASET_RECORDS[0],
+          updateFrequency: null,
+        }
+        fixture.detectChanges()
+      })
+      it('should not display the updateFrequency section', () => {
+        const displayedElement =
+          fixture.nativeElement.querySelector('.updateFrequency')
+        expect(displayedElement).toBeFalsy()
+      })
+    })
     describe('updateFrequency as UpdateFrequencyCode', () => {
       beforeEach(() => {
         fixture = TestBed.createComponent(MetadataInfoComponent)

diff --git a/libs/ui/elements/src/lib/metadata-info/metadata-info.component.ts b/libs/ui/elements/src/lib/metadata-info/metadata-info.component.ts
@@ -42,8 +42,10 @@ export class MetadataInfoComponent {
     if (this.metadata.updateFrequency instanceof Object) {
       this.updatedTimes = this.metadata.updateFrequency.updatedTimes
       return `domain.record.updateFrequency.${this.metadata.updateFrequency.per}`
-    } else {
+    } else if (typeof this.metadata.updateFrequency === 'string') {
       return `domain.record.updateFrequency.${this.metadata.updateFrequency}`
+    } else {
+      return undefined
     }
   }