fix code review

geonetwork · Aug 21, 2024 · 6bfecee · 6bfecee
1 parent d5256dd
commit 6bfecee
Show file tree

Hide file tree

Showing 9 changed files with 190 additions and 175 deletions.
diff --git a/libs/common/domain/src/lib/model/record/contact.model.ts b/libs/common/domain/src/lib/model/record/contact.model.ts
@@ -25,37 +25,31 @@ export const RoleValues = [
   'user', // Party who uses the resource
 ]
 
-export const RoleLabels = new Map<string, string>([
-  ['unspecified', marker('metadata.contactForResource.role.unspecified')],
-  ['other', marker('metadata.contactForResource.role.other')],
-  ['author', marker('metadata.contactForResource.role.author')],
-  ['collaborator', marker('metadata.contactForResource.role.collaborator')],
-  ['contributor', marker('metadata.contactForResource.role.contributor')],
-  ['custodian', marker('metadata.contactForResource.role.custodian')],
-  ['distributor', marker('metadata.contactForResource.role.distributor')],
-  ['editor', marker('metadata.contactForResource.role.editor')],
-  ['funder', marker('metadata.contactForResource.role.funder')],
-  ['mediator', marker('metadata.contactForResource.role.mediator')],
-  ['originator', marker('metadata.contactForResource.role.originator')],
-  ['owner', marker('metadata.contactForResource.role.owner')],
-  [
-    'point_of_contact',
-    marker('metadata.contactForResource.role.point_of_contact'),
-  ],
+export const RoleLabels = new Map<Role, string>([
+  ['unspecified', marker('domain.contact.role.unspecified')],
+  ['other', marker('domain.contact.role.other')],
+  ['author', marker('domain.contact.role.author')],
+  ['collaborator', marker('domain.contact.role.collaborator')],
+  ['contributor', marker('domain.contact.role.contributor')],
+  ['custodian', marker('domain.contact.role.custodian')],
+  ['distributor', marker('domain.contact.role.distributor')],
+  ['editor', marker('domain.contact.role.editor')],
+  ['funder', marker('domain.contact.role.funder')],
+  ['mediator', marker('domain.contact.role.mediator')],
+  ['originator', marker('domain.contact.role.originator')],
+  ['owner', marker('domain.contact.role.owner')],
+  ['point_of_contact', marker('domain.contact.role.point_of_contact')],
   [
     'principal_investigator',
-    marker('metadata.contactForResource.role.principal_investigator'),
-  ],
-  ['processor', marker('metadata.contactForResource.role.processor')],
-  ['publisher', marker('metadata.contactForResource.role.publisher')],
-  [
-    'resource_provider',
-    marker('metadata.contactForResource.role.resource_provider'),
+    marker('domain.contact.role.principal_investigator'),
   ],
-  ['rights_holder', marker('metadata.contactForResource.role.rights_holder')],
-  ['sponsor', marker('metadata.contactForResource.role.sponsor')],
-  ['stakeholder', marker('metadata.contactForResource.role.stakeholder')],
-  ['user', marker('metadata.contactForResource.role.user')],
+  ['processor', marker('domain.contact.role.processor')],
+  ['publisher', marker('domain.contact.role.publisher')],
+  ['resource_provider', marker('domain.contact.role.resource_provider')],
+  ['rights_holder', marker('domain.contact.role.rights_holder')],
+  ['sponsor', marker('domain.contact.role.sponsor')],
+  ['stakeholder', marker('domain.contact.role.stakeholder')],
+  ['user', marker('domain.contact.role.user')],
 ])
 
 export type Role = typeof RoleValues[number]

diff --git a/translations/de.json b/translations/de.json
@@ -147,6 +147,27 @@
   "dataset.error.parse": "Die Daten wurden geladen, konnten aber nicht gelesen werden: \"{ info }\"",
   "dataset.error.unknown": "Die Daten können nicht angezeigt werden: \"{ info }\"",
   "dataset.error.unsupportedType": "Der folgende Inhaltstyp wird nicht unterstützt: \"{ info }\"",
+  "domain.contact.role.author": "",
+  "domain.contact.role.collaborator": "",
+  "domain.contact.role.contributor": "",
+  "domain.contact.role.custodian": "",
+  "domain.contact.role.distributor": "",
+  "domain.contact.role.editor": "",
+  "domain.contact.role.funder": "",
+  "domain.contact.role.mediator": "",
+  "domain.contact.role.originator": "",
+  "domain.contact.role.other": "",
+  "domain.contact.role.owner": "",
+  "domain.contact.role.point_of_contact": "",
+  "domain.contact.role.principal_investigator": "",
+  "domain.contact.role.processor": "",
+  "domain.contact.role.publisher": "",
+  "domain.contact.role.resource_provider": "",
+  "domain.contact.role.rights_holder": "",
+  "domain.contact.role.sponsor": "",
+  "domain.contact.role.stakeholder": "",
+  "domain.contact.role.unspecified": "",
+  "domain.contact.role.user": "",
   "domain.record.status.completed": "Abgeschlossen",
   "domain.record.status.deprecated": "Veraltet",
   "domain.record.status.ongoing": "Kontinuierliche Aktualisierung",

diff --git a/translations/en.json b/translations/en.json
@@ -147,6 +147,27 @@
   "dataset.error.parse": "The data was loaded but could not be parsed: \"{ info }\"",
   "dataset.error.unknown": "The data cannot be displayed: \"{ info }\"",
   "dataset.error.unsupportedType": "The following content type is unsupported: \"{ info }\"",
+  "domain.contact.role.author": "Author",
+  "domain.contact.role.collaborator": "Collaborator",
+  "domain.contact.role.contributor": "Contributor",
+  "domain.contact.role.custodian": "Custodian",
+  "domain.contact.role.distributor": "Distributor",
+  "domain.contact.role.editor": "Editor",
+  "domain.contact.role.funder": "Funder",
+  "domain.contact.role.mediator": "Mediator",
+  "domain.contact.role.originator": "Originator",
+  "domain.contact.role.other": "Other",
+  "domain.contact.role.owner": "Owner",
+  "domain.contact.role.point_of_contact": "Point of contact",
+  "domain.contact.role.principal_investigator": "Principal investigator",
+  "domain.contact.role.processor": "Processor",
+  "domain.contact.role.publisher": "Publisher",
+  "domain.contact.role.resource_provider": "Resource provider",
+  "domain.contact.role.rights_holder": "Rights holder",
+  "domain.contact.role.sponsor": "Sponsor",
+  "domain.contact.role.stakeholder": "Stakeholder",
+  "domain.contact.role.unspecified": "Unspecified",
+  "domain.contact.role.user": "User",
   "domain.record.status.completed": "Completed",
   "domain.record.status.deprecated": "Deprecated",
   "domain.record.status.ongoing": "On going",
@@ -289,27 +310,6 @@
   "map.select.layer": "Data source",
   "map.wfs.urlInput.hint": "Enter WFS service URL",
   "map.wms.urlInput.hint": "Enter WMS service URL",
-  "metadata.contactForResource.role.author": "Author",
-  "metadata.contactForResource.role.collaborator": "Collaborator",
-  "metadata.contactForResource.role.contributor": "Contributor",
-  "metadata.contactForResource.role.custodian": "Custodian",
-  "metadata.contactForResource.role.distributor": "Distributor",
-  "metadata.contactForResource.role.editor": "Editor",
-  "metadata.contactForResource.role.funder": "Funder",
-  "metadata.contactForResource.role.mediator": "Mediator",
-  "metadata.contactForResource.role.originator": "Originator",
-  "metadata.contactForResource.role.other": "Other",
-  "metadata.contactForResource.role.owner": "Owner",
-  "metadata.contactForResource.role.point_of_contact": "Point of contact",
-  "metadata.contactForResource.role.principal_investigator": "Principal investigator",
-  "metadata.contactForResource.role.processor": "Processor",
-  "metadata.contactForResource.role.publisher": "Publisher",
-  "metadata.contactForResource.role.resource_provider": "Resource provider",
-  "metadata.contactForResource.role.rights_holder": "Rights holder",
-  "metadata.contactForResource.role.sponsor": "Sponsor",
-  "metadata.contactForResource.role.stakeholder": "Stakeholder",
-  "metadata.contactForResource.role.unspecified": "Unspecified",
-  "metadata.contactForResource.role.user": "User",
   "multiselect.filter.placeholder": "Search",
   "nav.back": "Back",
   "next": "next",

diff --git a/translations/es.json b/translations/es.json
@@ -147,6 +147,27 @@
   "dataset.error.parse": "",
   "dataset.error.unknown": "",
   "dataset.error.unsupportedType": "",
+  "domain.contact.role.author": "",
+  "domain.contact.role.collaborator": "",
+  "domain.contact.role.contributor": "",
+  "domain.contact.role.custodian": "",
+  "domain.contact.role.distributor": "",
+  "domain.contact.role.editor": "",
+  "domain.contact.role.funder": "",
+  "domain.contact.role.mediator": "",
+  "domain.contact.role.originator": "",
+  "domain.contact.role.other": "",
+  "domain.contact.role.owner": "",
+  "domain.contact.role.point_of_contact": "",
+  "domain.contact.role.principal_investigator": "",
+  "domain.contact.role.processor": "",
+  "domain.contact.role.publisher": "",
+  "domain.contact.role.resource_provider": "",
+  "domain.contact.role.rights_holder": "",
+  "domain.contact.role.sponsor": "",
+  "domain.contact.role.stakeholder": "",
+  "domain.contact.role.unspecified": "",
+  "domain.contact.role.user": "",
   "domain.record.status.completed": "",
   "domain.record.status.deprecated": "",
   "domain.record.status.ongoing": "",
@@ -289,27 +310,6 @@
   "map.select.layer": "",
   "map.wfs.urlInput.hint": "",
   "map.wms.urlInput.hint": "",
-  "metadata.contactForResource.role.author": "",
-  "metadata.contactForResource.role.collaborator": "",
-  "metadata.contactForResource.role.contributor": "",
-  "metadata.contactForResource.role.custodian": "",
-  "metadata.contactForResource.role.distributor": "",
-  "metadata.contactForResource.role.editor": "",
-  "metadata.contactForResource.role.funder": "",
-  "metadata.contactForResource.role.mediator": "",
-  "metadata.contactForResource.role.originator": "",
-  "metadata.contactForResource.role.other": "",
-  "metadata.contactForResource.role.owner": "",
-  "metadata.contactForResource.role.point_of_contact": "",
-  "metadata.contactForResource.role.principal_investigator": "",
-  "metadata.contactForResource.role.processor": "",
-  "metadata.contactForResource.role.publisher": "",
-  "metadata.contactForResource.role.resource_provider": "",
-  "metadata.contactForResource.role.rights_holder": "",
-  "metadata.contactForResource.role.sponsor": "",
-  "metadata.contactForResource.role.stakeholder": "",
-  "metadata.contactForResource.role.unspecified": "",
-  "metadata.contactForResource.role.user": "",
   "multiselect.filter.placeholder": "",
   "nav.back": "",
   "next": "",

diff --git a/translations/fr.json b/translations/fr.json
@@ -147,6 +147,27 @@
   "dataset.error.parse": "Les données ont été chargées mais leur décodage a échoué: \"{ info }\"",
   "dataset.error.unknown": "Les données ne peuvent être affichées: \"{ info }\"",
   "dataset.error.unsupportedType": "Le type de contenu suivant n'est pas pris en charge: \"{ info }\"",
+  "domain.contact.role.author": "Auteur",
+  "domain.contact.role.collaborator": "Collaborateur",
+  "domain.contact.role.contributor": "Contributeur",
+  "domain.contact.role.custodian": "Gestionnaire",
+  "domain.contact.role.distributor": "Distributeur",
+  "domain.contact.role.editor": "Éditeur",
+  "domain.contact.role.funder": "Financeur",
+  "domain.contact.role.mediator": "Médiateur",
+  "domain.contact.role.originator": "Créateur",
+  "domain.contact.role.other": "Autre",
+  "domain.contact.role.owner": "Propriétaire",
+  "domain.contact.role.point_of_contact": "Point de contact",
+  "domain.contact.role.principal_investigator": "Chercheur principal",
+  "domain.contact.role.processor": "Processeur",
+  "domain.contact.role.publisher": "Éditeur",
+  "domain.contact.role.resource_provider": "Fournisseur",
+  "domain.contact.role.rights_holder": "Détenteur des droits",
+  "domain.contact.role.sponsor": "Sponsor",
+  "domain.contact.role.stakeholder": "Partie prenante",
+  "domain.contact.role.unspecified": "Non spécifié",
+  "domain.contact.role.user": "Utilisateur",
   "domain.record.status.completed": "Finalisé",
   "domain.record.status.deprecated": "Obsolète",
   "domain.record.status.ongoing": "Mise à jour continue",
@@ -289,27 +310,6 @@
   "map.select.layer": "Source de données",
   "map.wfs.urlInput.hint": "Entrez l'URL du service WFS",
   "map.wms.urlInput.hint": "Entrez l'URL du service WMS",
-  "metadata.contactForResource.role.author": "Auteur",
-  "metadata.contactForResource.role.collaborator": "Collaborateur",
-  "metadata.contactForResource.role.contributor": "Contributeur",
-  "metadata.contactForResource.role.custodian": "Gestionnaire",
-  "metadata.contactForResource.role.distributor": "Distributeur",
-  "metadata.contactForResource.role.editor": "Éditeur",
-  "metadata.contactForResource.role.funder": "Financeur",
-  "metadata.contactForResource.role.mediator": "Médiateur",
-  "metadata.contactForResource.role.originator": "Créateur",
-  "metadata.contactForResource.role.other": "Autre",
-  "metadata.contactForResource.role.owner": "Propriétaire",
-  "metadata.contactForResource.role.point_of_contact": "Point de contact",
-  "metadata.contactForResource.role.principal_investigator": "Chercheur principal",
-  "metadata.contactForResource.role.processor": "Processeur",
-  "metadata.contactForResource.role.publisher": "Éditeur",
-  "metadata.contactForResource.role.resource_provider": "Fournisseur",
-  "metadata.contactForResource.role.rights_holder": "Détenteur des droits",
-  "metadata.contactForResource.role.sponsor": "Sponsor",
-  "metadata.contactForResource.role.stakeholder": "Partie prenante",
-  "metadata.contactForResource.role.unspecified": "Non spécifié",
-  "metadata.contactForResource.role.user": "Utilisateur",
   "multiselect.filter.placeholder": "Rechercher",
   "nav.back": "Retour",
   "next": "suivant",

diff --git a/translations/it.json b/translations/it.json
@@ -147,6 +147,27 @@
   "dataset.error.parse": "I dati sono stati caricati ma la decodifica non è riuscita: \"{info}\"",
   "dataset.error.unknown": "Impossibile visualizzare i dati: \"{info}\"",
   "dataset.error.unsupportedType": "Il seguente tipo di contenuto non è supportato: \"{info}\"",
+  "domain.contact.role.author": "",
+  "domain.contact.role.collaborator": "",
+  "domain.contact.role.contributor": "",
+  "domain.contact.role.custodian": "",
+  "domain.contact.role.distributor": "",
+  "domain.contact.role.editor": "",
+  "domain.contact.role.funder": "",
+  "domain.contact.role.mediator": "",
+  "domain.contact.role.originator": "",
+  "domain.contact.role.other": "",
+  "domain.contact.role.owner": "",
+  "domain.contact.role.point_of_contact": "",
+  "domain.contact.role.principal_investigator": "",
+  "domain.contact.role.processor": "",
+  "domain.contact.role.publisher": "",
+  "domain.contact.role.resource_provider": "",
+  "domain.contact.role.rights_holder": "",
+  "domain.contact.role.sponsor": "",
+  "domain.contact.role.stakeholder": "",
+  "domain.contact.role.unspecified": "",
+  "domain.contact.role.user": "",
   "domain.record.status.completed": "Completato",
   "domain.record.status.deprecated": "Deprecato",
   "domain.record.status.ongoing": "Aggiornamento continuo",
@@ -289,27 +310,6 @@
   "map.select.layer": "Sorgente dati",
   "map.wfs.urlInput.hint": "Inserisci URL del servizio WFS",
   "map.wms.urlInput.hint": "Inserisci URL del servizio WMS",
-  "metadata.contactForResource.role.author": "",
-  "metadata.contactForResource.role.collaborator": "",
-  "metadata.contactForResource.role.contributor": "",
-  "metadata.contactForResource.role.custodian": "",
-  "metadata.contactForResource.role.distributor": "",
-  "metadata.contactForResource.role.editor": "",
-  "metadata.contactForResource.role.funder": "",
-  "metadata.contactForResource.role.mediator": "",
-  "metadata.contactForResource.role.originator": "",
-  "metadata.contactForResource.role.other": "",
-  "metadata.contactForResource.role.owner": "",
-  "metadata.contactForResource.role.point_of_contact": "",
-  "metadata.contactForResource.role.principal_investigator": "",
-  "metadata.contactForResource.role.processor": "",
-  "metadata.contactForResource.role.publisher": "",
-  "metadata.contactForResource.role.resource_provider": "",
-  "metadata.contactForResource.role.rights_holder": "",
-  "metadata.contactForResource.role.sponsor": "",
-  "metadata.contactForResource.role.stakeholder": "",
-  "metadata.contactForResource.role.unspecified": "",
-  "metadata.contactForResource.role.user": "",
   "multiselect.filter.placeholder": "Cerca",
   "nav.back": "Indietro",
   "next": "successivo",

diff --git a/translations/nl.json b/translations/nl.json
@@ -147,6 +147,27 @@
   "dataset.error.parse": "",
   "dataset.error.unknown": "",
   "dataset.error.unsupportedType": "",
+  "domain.contact.role.author": "",
+  "domain.contact.role.collaborator": "",
+  "domain.contact.role.contributor": "",
+  "domain.contact.role.custodian": "",
+  "domain.contact.role.distributor": "",
+  "domain.contact.role.editor": "",
+  "domain.contact.role.funder": "",
+  "domain.contact.role.mediator": "",
+  "domain.contact.role.originator": "",
+  "domain.contact.role.other": "",
+  "domain.contact.role.owner": "",
+  "domain.contact.role.point_of_contact": "",
+  "domain.contact.role.principal_investigator": "",
+  "domain.contact.role.processor": "",
+  "domain.contact.role.publisher": "",
+  "domain.contact.role.resource_provider": "",
+  "domain.contact.role.rights_holder": "",
+  "domain.contact.role.sponsor": "",
+  "domain.contact.role.stakeholder": "",
+  "domain.contact.role.unspecified": "",
+  "domain.contact.role.user": "",
   "domain.record.status.completed": "",
   "domain.record.status.deprecated": "",
   "domain.record.status.ongoing": "",
@@ -289,27 +310,6 @@
   "map.select.layer": "",
   "map.wfs.urlInput.hint": "",
   "map.wms.urlInput.hint": "",
-  "metadata.contactForResource.role.author": "",
-  "metadata.contactForResource.role.collaborator": "",
-  "metadata.contactForResource.role.contributor": "",
-  "metadata.contactForResource.role.custodian": "",
-  "metadata.contactForResource.role.distributor": "",
-  "metadata.contactForResource.role.editor": "",
-  "metadata.contactForResource.role.funder": "",
-  "metadata.contactForResource.role.mediator": "",
-  "metadata.contactForResource.role.originator": "",
-  "metadata.contactForResource.role.other": "",
-  "metadata.contactForResource.role.owner": "",
-  "metadata.contactForResource.role.point_of_contact": "",
-  "metadata.contactForResource.role.principal_investigator": "",
-  "metadata.contactForResource.role.processor": "",
-  "metadata.contactForResource.role.publisher": "",
-  "metadata.contactForResource.role.resource_provider": "",
-  "metadata.contactForResource.role.rights_holder": "",
-  "metadata.contactForResource.role.sponsor": "",
-  "metadata.contactForResource.role.stakeholder": "",
-  "metadata.contactForResource.role.unspecified": "",
-  "metadata.contactForResource.role.user": "",
   "multiselect.filter.placeholder": "",
   "nav.back": "",
   "next": "",