Merge pull request #884 from geonetwork/fix-data-not-found

[Datahub]: Fix missing "record not found" message
geonetwork · May 29, 2024 · 549700b · 549700b
2 parents ff2a9db + 46f507b
commit 549700b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 9 deletions.
diff --git a/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts b/apps/datahub-e2e/src/e2e/datasetDetailPage.cy.ts
@@ -797,3 +797,12 @@ describe('userFeedback', () => {
     })
   })
 })
+
+describe('When the metadata does not exists', () => {
+  beforeEach(() => {
+    cy.visit('/dataset/xyz')
+  })
+  it('should display an error message', () => {
+    cy.get('gn-ui-search-results-error').should('exist')
+  })
+})
diff --git a/apps/datahub/src/app/record/record-metadata/record-metadata.component.html b/apps/datahub/src/app/record/record-metadata/record-metadata.component.html
@@ -148,13 +148,17 @@
       <div class="container-lg mx-auto h-[1096px] sm:h-96"></div>
     </div>
   </div>
-</div>
-<div id="userFeedbacks" class="bg-primary-opacity-10 py-16 mt-[32px]">
-  <div class="container-lg px-4 lg:mx-auto">
-    <datahub-record-user-feedbacks
-      [organisationName$]="organisationName$"
-      [metadataUuid]="metadataUuid$ | async"
-    ></datahub-record-user-feedbacks>
+  <div
+    *ngIf="(metadataViewFacade.isPresent$ | async) === true"
+    id="userFeedbacks"
+    class="bg-primary-opacity-10 py-16 mt-[32px]"
+  >
+    <div class="container-lg px-4 lg:mx-auto">
+      <datahub-record-user-feedbacks
+        [organisationName$]="organisationName$"
+        [metadataUuid]="metadataUuid$ | async"
+      ></datahub-record-user-feedbacks>
+    </div>
   </div>
 </div>
 <div

diff --git a/libs/feature/record/src/lib/state/mdview.reducer.ts b/libs/feature/record/src/lib/state/mdview.reducer.ts
@@ -82,7 +82,6 @@ const metadataViewReducer = createReducer(
   */
   on(MetadataViewActions.loadUserFeedbacks, (state) => ({
     ...state,
-    error: null,
     allUserFeedbacksLoading: true,
   })),
   on(MetadataViewActions.addUserFeedback, (state) => ({
@@ -93,7 +92,6 @@ const metadataViewReducer = createReducer(
     MetadataViewActions.loadUserFeedbacksSuccess,
     (state, { userFeedbacks }) => ({
       ...state,
-      error: null,
       userFeedbacks: userFeedbacks,
       addUserFeedbackLoading: false,
       allUserFeedbacksLoading: false,