test(elasticsearch): use TestBed for service creation

geonetwork · Nov 3, 2023 · 020fa07 · 020fa07
1 parent e70070d
commit 020fa07
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 7 deletions.
diff --git a/libs/api/repository/src/lib/gn4/elasticsearch/elasticsearch.service.spec.ts b/libs/api/repository/src/lib/gn4/elasticsearch/elasticsearch.service.spec.ts
@@ -2,17 +2,31 @@ import { ElasticsearchService } from './elasticsearch.service'
 import { ES_FIXTURE_AGGS_RESPONSE } from '@geonetwork-ui/common/fixtures'
 import { LangService } from '@geonetwork-ui/util/i18n'
 import { EsSearchParams } from '@geonetwork-ui/api/metadata-converter'
+import { TestBed } from '@angular/core/testing'
+import { METADATA_LANGUAGE } from '../../metadata-language'
 
-const langServiceMock = {
-  iso3: 'eng',
-} as LangService
+class LangServiceMock {
+  iso3 = 'eng'
+}
 
 describe('ElasticsearchService', () => {
   let service: ElasticsearchService
   let searchFilters
 
   beforeEach(() => {
-    service = new ElasticsearchService(langServiceMock, 'fre')
+    TestBed.configureTestingModule({
+      providers: [
+        {
+          provide: LangService,
+          useClass: LangServiceMock,
+        },
+        {
+          provide: METADATA_LANGUAGE,
+          useValue: 'fre',
+        },
+      ],
+    })
+    service = TestBed.inject(ElasticsearchService)
   })
 
   it('should be created', () => {

diff --git a/libs/api/repository/src/lib/gn4/elasticsearch/elasticsearch.service.ts b/libs/api/repository/src/lib/gn4/elasticsearch/elasticsearch.service.ts
@@ -201,11 +201,11 @@ export class ElasticsearchService {
   }
 
   private getQueryLang(): string {
-    return this.metadataLang
-      ? this.isCurrentSearchLang()
+    if (this.metadataLang) {
+      return this.isCurrentSearchLang()
         ? `lang${this.lang3}`
         : `lang${this.metadataLang}`
-      : `*`
+    } else return '*'
   }
   private isCurrentSearchLang() {
     return this.metadataLang === 'current'