Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage non existent processes in check status end-points #10

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

josegar74
Copy link
Member

Return the status of the components with a error to indicate that the process id provided doesn't exist, so the applications using the end-points can manage these cases.

Without the change the log file can be full of exceptions like this:

csw-harvester  | java.util.NoSuchElementException: No value present
csw-harvester  | 	at java.util.Optional.get(Optional.java:135)
csw-harvester  | 	at geocat.database.service.HarvestJobService.getById(HarvestJobService.java:81)
csw-harvester  | 	at geocat.service.GetStatusService.getStatus(GetStatusService.java:48)

@josegar74 josegar74 force-pushed the checkstatus-nonexistingprocesshandling branch from a57880e to e1fcbe5 Compare October 9, 2023 12:09
@josegar74 josegar74 merged commit f35d1de into main Oct 12, 2023
6 of 10 checks passed
@juanluisrp juanluisrp deleted the checkstatus-nonexistingprocesshandling branch October 13, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant