[FP] TransactionManager improvements #6052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jody Garnett <[email protected]> Co-authored-by: cmangeat
jodygarnett
approved these changes
Dec 30, 2021
jodygarnett
reviewed
Dec 30, 2021
| if ( status == null || status.isCompleted()){ | ||
| // not calling return here to preserve previous logic | ||
| // we can check if the following log messages are seen before taking defensive action | ||
| Log.debug( Log.JEEVES,"transactionManager.commit called unexpectedly when transaction is already completed "); |
There was a problem hiding this comment.
I did not want to be agressive with calling out invalid state like this while doing improvements, since this is on master we could change this to a warning or even failure.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Jody Garnett [email protected]
Co-authored-by: cmangeat
Related to #5308 committed to 3.12.x branch