-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor / Keep tabs at top. #5463
base: 3.12.x
Are you sure you want to change the base?
Conversation
Great idea, it works as expected, thanks! But there are a couple of visual things that caught my attention:
|
…into enhancement/top-tabs
I struggled to address the issue with content appearing above the tabs, but I reduced some of the issues by enlarging the width which I'm filling in with (now) white. As for the spacing between the tabs and their underline, that was already present before I started this work. It looks like GN is what adds the underline (making it easy to e.g. remove), but I'm not seeing where that gap comes from. Probably Bootstrap. |
My apologies for keeping this PR open for so long. I played around with some styles and to remove the gap you can do this for the toggle:
and for the
only thing is, a fixed Another option would be to put the |
ByronCinNZ seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This keeps the tabs always within reach no matter how far down the page you scroll. Design feedback appreciated!