Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

point as bounding-polygon #5399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pvgenuchten
Copy link

this brings in some features from 3.10 to use a point as boundingpolygon, resolves #4811 for gn4
this manages the schema and ui part, aspects of #5396 may be required to get the full feature supported

@GeoSander
Copy link
Contributor

I didn't test on GN4, but it looks good/complete to me.

@pvgenuchten
Copy link
Author

pvgenuchten commented Feb 2, 2021

point gets correctly added and displayed to editor, a fix is required on extent api (currently returns: No region with metadata:@id125 found).

@fxprunayre
Copy link
Member

point gets correctly added and displayed to editor,

Should we change label "bounding polygon" by bounding geometry ?

image

it could also make sense to have same layout for tools in bbox and geometry ? Maybe Michel has time to have a look ? Button toolbar and color ? But could be in another PR.

@MichelGabriel
Copy link
Contributor

bounding geometry

Yes, that's fits better

@MichelGabriel
Copy link
Contributor

I did have a look, have some ideas, but will make a new PR for it

@pvgenuchten
Copy link
Author

added label fix as suggested by @fxprunayre

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Paul seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spatial Extent problem with points
5 participants