Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve competing war and jetty run definitions #5329

Draft
wants to merge 2 commits into
base: 3.12.x
Choose a base branch
from

Conversation

jodygarnett
Copy link
Contributor

@jodygarnett jodygarnett commented Jan 11, 2021

This work removes the need for a mvn process-resources when trying out changes using jetty:run, instead files are edited directly.

This pull request seeks to make jetty:run work directly from many folders and file locations for quick feedback, while letting war:war be very explicit about working with named and versioned dependencies for isolated builds.

  • migrate
  • web-ui
  • web: package-resources and compile steps for war
  • web: war
  • web: jetty

The gold standard we are working for here is the ability to check out a branch to work on a single problem only building the modules that are being changed. Description from proposal: Resolve competing web module war definitions

The web app contains competing build configurations (for both war:war and jetty:run) on the management of schema-plugins leading to build instability.

This proposal refactors web module structure to resolve this issue.

This proposal should simplify the build experience for everyone, and preserve the developer workflow you are used to, and document the result so it is easier to understand where to make any changes.

Since this proposal was written additional needless complexity has been pointed out, this can be explored in subsequent pull requests.

@jodygarnett
Copy link
Contributor Author

This first commit shows sucessfully isolating sql migrate scripts into a distinct module.

  • option: consider moving all the sql resources to the new module. New module would have a clear focus and would be responsible for all the database dependencies
  • option: consider simplify content into src/java and src/resources to folders (the result is compiled into WEB-INF/classes at the end of the day)

Leaving this in place for now as the rest of the proposal has far more serious work to address.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants