Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize modification notes from authoritative source #17

Merged

Conversation

HassanAkbar
Copy link
Member

Recognize modification notes from authoritative source relationship field

closes #16

@HassanAkbar
Copy link
Member Author

@strogonoff One thing that I noticed is that the spelling of modification key is wrong in the yaml file.

@strogonoff
Copy link
Contributor

I am not familiar enough with this project to properly understand the changes. Any potential problems if we merge this?

@strogonoff
Copy link
Contributor

@strogonoff One thing that I noticed is that the spelling of modification key is wrong in the yaml file.

This I believe has been fixed since.

@HassanAkbar
Copy link
Member Author

@strogonoff Verified, this has been fixed.

Copy link
Member

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HassanAkbar ! Can you please help merge and release? Thanks.

@HassanAkbar HassanAkbar merged commit cffcb03 into main Nov 23, 2023
27 checks passed
@HassanAkbar HassanAkbar deleted the recognize_modification_notes_from_authoritative_source branch November 23, 2023 10:59
@HassanAkbar
Copy link
Member Author

@ronaldtse released version 1.8.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognize modification notes from authoritative source relationship field
3 participants