Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subsection for random uniform particle generator #6092

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

gassmoeller
Copy link
Member

This is in response to https://community.geodynamics.org/t/cannot-specify-the-number-of-particles-with-random-uniform-particle-generator/3709/2. It was a mistake to let the 'random uniform' particle generator use the same subsection as the 'probability density function'. I think this was a leftover, because 'random uniform' used to be a child class of 'probability density function'. The change is straightforward, except the update script implementation is a bit complicated, because it needs to handle two cases:

  1. .prm files older than the update of the particle parameters need to move 'Number of particles' into the new 'Random uniform' subsection.
  2. .prm files younger than the update (or which have already been updated) need to move the whole subsection of 'Probability density function' to the new 'Random uniform' subsection.

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the right time to change this!

I think you might want to add a changelog entry. OK to merge if you do!

@bangerth bangerth merged commit d91e41b into geodynamics:main Oct 18, 2024
8 checks passed
@bangerth
Copy link
Contributor

Ah, it tests correctly. Let's just merge. Please add the changelog separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants