Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the discussion about how plugins work in the documentation. #6060

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

bangerth
Copy link
Contributor

@bangerth bangerth commented Oct 9, 2024

While finishing up #1775.

Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks for the update. Feel free to merge yourself after addressing my comment.

doc/sphinx/user/extending/idea-of-plugins.md Outdated Show resolved Hide resolved
above. On the other hand, if the new model does not need any run-time
input file, you also need to have functions called `declare_parameters()`
and `parse_parameters()` in your class with the same signatures as the ones
declared in the `Plugins::Interface` base class.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
declared in the `Plugins::Interface` base class.
declared in the `Plugins::InterfaceBase` base class.

@gassmoeller gassmoeller merged commit 0a579e6 into geodynamics:main Oct 9, 2024
8 checks passed
@bangerth bangerth deleted the plugins branch October 9, 2024 17:13
@bangerth
Copy link
Contributor Author

bangerth commented Oct 9, 2024

Thanks for fixing the typo yourself :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants