Rename particle world to particle manager #6058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion resulting from the discussion in the user meeting yesterday about a better name for the particle world class. See my reasoning for the renaming here. I think the most convincing suggestion was to try the name
Manager
, because it most directly explains the purpose of the class, and it is nicely analogous to all the existing manager classes we have already. Part of me is sad to seeWorld
go, because the name had something poetic about it (all the particles living in their own world 😄). But I think the new term is better, and the implementation was simpler than expected. I even found a way to make moving the files and renaming the class backward compatible by keeping the main header file around and by declaring an alias for theWorld
class name. This PR is mostly a lot of search and replace, but in essence it does:world
tomanager
, incl. theParticle::World
class name, the simulator access functions, and the new cmake variable and input/output parameters.world.[h,cc]
tomanager.[h,cc]
. Also rename all existing test files.world.h
header file that enables backward compatibility for existing user plugins.simulator_access.get_particle_world()
to the newsimulator_access.get_particle_manager(0)
. I assumed we would mostly update files from before Add further multiple particle world instrastructure. #5920 which introduced the new function parameter.Number of particle managers
from the global subsection into theParticles
subsection. I think this is more appropriate and aligns closer with how things are done for compositional fields (Compositional fields/Number of compositional fields
).@MFraters, @tjhei, @bangerth: You were most closely involved in the discussion, can you take a look? It is a lot of changes, but almost all of it is simple search/replace.