fix test for weighted BFBT preconditioner #6057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Oct 8, 2024
tests/burnman_bfbt_test.prm
Outdated
| @@ -0,0 +1,145 @@ | |||
| # A test using adiabatic conditions and a gravity | |||
There was a problem hiding this comment.
Is this a copy of burnman.prm? If yes, just replace the comment on top to say that this is testing bfbt, include the other prm file, and delete everything except the solver section here
There was a problem hiding this comment.
Also can you add the file of the screen output as well?
|
This needs rebasing after #6059 is merged to fix the output. |
|
Thanks for the update. Please fix the indentation. |
|
Can you please rebase to the current main, push, wait for the tester, and update the output again? |
tjhei
approved these changes
Oct 10, 2024
tjhei
reviewed
Oct 11, 2024
tests/burnman_bfbt_test.prm
Outdated
| set Time steps between mesh refinement = 5 | ||
| end | ||
| subsection Solver parameters | ||
| subsection Stokes solver parameters |
There was a problem hiding this comment.
Please set the solver to block AMG here
add burnman bfbt test
tjhei
changed the title
tjhei
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add tests for the weighted BFBT preconditioner.
Regarding the existing nsinker_bfbt test, a flag is added to make it use the weighted BFBT preconditioner.