Test for multiple particle interpolation #6054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #5877. |
gassmoeller
force-pushed
the
test_for_multiple_particle_interpolation
branch
from
7e74678
to
a0598b2
Compare
|
Would you mind rebasing? |
gassmoeller
force-pushed
the
test_for_multiple_particle_interpolation
branch
from
e2554a6
to
61f4214
Compare
|
Rebased. |
tjhei
approved these changes
Oct 6, 2024
| particle_property_indices[world_index].push_back({advection_field,particle_property_index}); | ||
| property_mask[world_index].set(particle_property_index,true); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| for (unsigned int advection_field=0; advection_field<advection_fields.size(); ++advection_field) | ||
| Assert (advection_field_has_been_found[advection_field] == true, |
There was a problem hiding this comment.
would you mind adding advection_field to the error message?
| @@ -306,9 +311,13 @@ namespace aspect | |||
| // If not: assume we find it in another world. | |||
| if (particle_property_manager.get_data_info().fieldname_exists(particle_property_and_component.first)) | |||
| { | |||
| Assert (advection_field_has_been_found[advection_field] == false, | |||
| ExcMessage("The same advection field is mapped to particle properties in different particle worlds. This is not supported.")); | |||
gassmoeller
force-pushed
the
test_for_multiple_particle_interpolation
branch
from
ef2e6e6
to
920201e
Compare
|
Something like this? |
tjhei
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6052 that adds additional safety checks for interpolation from multiple particle worlds, and tests that we can correctly interpolate particle properties from multiple particle worlds into compositional fields.