Support multiple particle sets #6045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
Sep 21, 2024
|
Can you move this list into the open issue? |
|
You marked this as [WIP], but feel free to merge. |
gassmoeller
force-pushed
the
support_multiple_particle_sets
branch
from
368aa92
to
b25c4c9
Compare
gassmoeller
changed the title
gassmoeller
force-pushed
the
support_multiple_particle_sets
branch
from
b25c4c9
to
aa02a48
Compare
|
Ok, I rebased after #6043 was merged and kept the limit of one particle world in, because we do not have tests for the multi-particle-world case yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MFraters, @tjhei this should check most remaining items off the list of #5877, in particular the interpolation and the load balancing. I think we are now at a stage where we need to add a lot of tests to this PR.
We should also think about a cookbook that illustrates how to use the multiple particle worlds.