Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] add elasticity to CompositeViscoPlastic #5984

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] add elasticity to CompositeViscoPlastic #5984

wants to merge 4 commits into from

Conversation

bobmyhill
Copy link
Member

@bobmyhill bobmyhill commented Jul 22, 2024 •
edited
Loading

PR requires functionality in #4370 for the additional outputs functions (commented out) to work.

This PR adds a Kelvin (viscoelastic) element to the CompositeViscoPlastic rheology:
image

The derivation of the rheological model can be found in this pdf.

Still a work in progess, opened for discussion and comments.

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@bobmyhill bobmyhill mentioned this pull request Jul 25, 2024
Merged
4 tasks
@bobmyhill bobmyhill force-pushed the composite_vep branch 5 times, most recently from 807dcae to e061e42 Compare July 31, 2024 14:47
@bobmyhill bobmyhill force-pushed the composite_vep branch 3 times, most recently from f76ed5a to ada9989 Compare August 11, 2024 22:45
anne-glerum
anne-glerum reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@anne-glerum anne-glerum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things I ran into when installing with the elastic functionality uncommented :)

include/aspect/material_model/rheology/composite_visco_plastic.h Outdated Show resolved Hide resolved
source/material_model/rheology/composite_visco_plastic.cc Show resolved Hide resolved
@bobmyhill bobmyhill mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anne-glerum anne-glerum anne-glerum left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
work in progress
Projects
Viscoelastoplasticity
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobmyhill @anne-glerum