use background field to calculate adiabatic profile #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Just a few typos. Ready otherwise.
Just for reference this is a fix for #5622.
| @@ -74,19 +74,13 @@ namespace aspect | |||
| in.requested_properties = MaterialModel::MaterialProperties::density | MaterialModel::MaterialProperties::additional_outputs; | |||
| in.velocity[0] = Tensor <1,dim> (); | |||
| // The entropy along an adiabat is constant (equals the surface entropy) | |||
| // TODO : need to make it work for more than one entropy field | |||
| // When there are more than one entropy field, we use the background field to compute adiabat profile | |||
There was a problem hiding this comment.
Suggested change
| // When there are more than one entropy field, we use the background field to compute adiabat profile | |
| // When there is more than one entropy field, we use the background field to compute the adiabatic profile |
RanpengLi
force-pushed
the
update-entropy-read-multi-test
branch
from
f9b090e
to
a81535d
Compare
|
Thank you! I have fix them accordingly. |
gassmoeller
approved these changes
Jun 4, 2024
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the result of an existing test. When having multiple components, we use the background field to calculate the adiabatic profile.