Add cutoff pressures to tian parameterization #5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
May 29, 2024
naliboff
reviewed
May 29, 2024
There was a problem hiding this comment.
@danieldouglas92 - Thanks for implementing this change. Reiterating my comment within the PR, are the cutoff values for each lithology reported in the Tian et al. paper, or did you determine them through testing? If the latter, would it be worth creating an input parameter where people can try adjusting the cutoff pressures?
danieldouglas92
force-pushed
the
add_pressure_bounds_to_tian
branch
2 times, most recently
from
c292cc1
to
e4f2374
Compare
naliboff
reviewed
May 29, 2024
danieldouglas92
force-pushed
the
add_pressure_bounds_to_tian
branch
from
86d4a2a
to
537e072
Compare
danieldouglas92
force-pushed
the
add_pressure_bounds_to_tian
branch
2 times, most recently
from
7af6c4c
to
8758f14
Compare
tjhei
reviewed
May 30, 2024
danieldouglas92
force-pushed
the
add_pressure_bounds_to_tian
branch
from
8758f14
to
91ccfca
Compare
tjhei
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polynomials used in the Tian parameterization for reactive two phase flow break down above certain pressures for each lithology, and the maximum bound water content becomes infinite. This PR ensures that the polynomial does not break down above these pressures by setting the pressure equal to the pressure just before the break down. An example of how this fix impacts the PT space for gabbro is shown below.
The python script that was used to determine these cutoff pressures can be found in the zip below.
Tian_water_content.py.zip