Remove unused particle code path #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These functions were the old (and slow) way to evaluate the solution at particle positions. They were necessary in the past, because FEPointEvaluation did not support all the mappings we use (in particular MappingCartesian) and prior to deal.II 9.4 there was a bug in FEPointEvaluation if evaluation started not a the first component of an FESystem. Both limitations have been fixed for a while and I couldnt think of (or find) any configuration in which we would still need the old code path. I still left an assert in that ensure we will not use the slow path of FEPointEvaluation (which is even slower than the implementation I am removing here). This will make sure that if someone uses an exotic mapping in the future, or other conditions change we at least learn about it.