Unify evaluation of number of material points #5639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
May 23, 2024
|
can you please rebase and resolve the conflict? |
gassmoeller
force-pushed
the
unify_output_point_evaluation
branch
from
a3a1db5
to
8e31e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaterialModelOutputsandMaterialModelInputshave functions to get the number of points it is supposed to be evaluated on. However, I found some old places that do not use that function and instead compute the number locally. This PR unifies the calling of this function in as many places I could find. I also removed a few checks for whether the strain_rate was provided to the material model, because since #5268 it is always provided.