Initialize uninitialized variable #5635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldouglas92
force-pushed
the
initialize_worldbuilder_variable
branch
from
802d04b
to
7558ad2
Compare
|
/rebuild |
bangerth
approved these changes
May 8, 2024
|
Timo's Mac OSX tester is down and currently inaccessible. I've merged since all of the other testers are happy. |
Yes, he also upstreamed it (see GeodynamicWorldBuilder/WorldBuilder#705). Thanks @danieldouglas92 for making the pull requests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to compile the development version of ASPECT on stampede3, an error gets thrown because this variable is uninitialized. Initializing this variable allows for the compiling to be successful. Also made this PR on the World Builder repo here.