Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log particle advection and update #5620

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

gassmoeller
Copy link
Member

This logs the point in time when particle advection and update actually happen, just like we do for compositional fields. This will change about every output, but I think it is worth it, because it clarifies that even when particles are listed as postprocessor their advection happens with the compositional fields.

Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it obvious what solving particles means? I would have called it "advecting particles..." or something similar.

Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like @tjhei I think this would read better if you said "Advecting particles..."

@gassmoeller
Copy link
Member Author

"Advecting particles ... " was actually what I had in a first version of this PR, but then I thought "Solving" is more similar to the other fields. Anyway, I agree Advecting is better. I have updated the code and will update the tests when the tester is done.

@gassmoeller
Copy link
Member Author

/rebuild

@gassmoeller
Copy link
Member Author

@tjhei It looks like the Jenkins tester is failing because of a timeout. Do you think there is something wrong with it, or should we just increase the time limit a bit (its set to 30 min for compile right now, and it seems to almost finish in time).

@tjhei
Copy link
Member

tjhei commented Apr 15, 2024

That is weird. I have to investigate if it is one of the machines. If the build doesn't complete in 30 minutes when it normally takes 5 minutes, the tests won't complete either. We can still build much faster, as you can see:
https://ci.tjhei.info/job/aspect/job/main/

@tjhei
Copy link
Member

tjhei commented Apr 15, 2024

It looks like the build hangs with one GCC process getting killed.

@tjhei tjhei merged commit 09c178d into geodynamics:main Apr 22, 2024
7 of 8 checks passed
@gassmoeller gassmoeller deleted the log_particle_advection branch April 22, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants