Update 'Peierls strain rate residual tolerance' #5609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense. Our testers have some problems right now, so this will need to wait a bit until we fix them. One question: #5338 chooses 1e-10 as a threshold, you here choose 1e-12. Any reason for that? Wouldnt it make more sense to use the same threshold? |
|
I chose 1e-12 because that's what I saw in most of the tests involving Peierls creep, but for consistency I can change it to 1e-10. |
danieldouglas92
force-pushed
the
update_peierls_strain_residual
branch
from
eef713b
to
7513f29
Compare
danieldouglas92
force-pushed
the
update_peierls_strain_residual
branch
from
7513f29
to
d247dbb
Compare
gassmoeller
approved these changes
Mar 26, 2024
|
/rebuild |
|
The only failing tests are unrelated, so I will merge this. Thanks for the improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #5338, the default value for the parameter
Peierls strain rate residual toleranceseemingly doesn't need to be so strict because the residual is now relative to the log of the strain rate. Opening this PR was motivated by models that I was running using the default value that could not converge, but using a value of 1e-10 - 1e-12 converged and produced negligible differences in the solution. Lowering the value should make models with Peierls creep more stable and faster when using the default value.This PR updates the documentation of this parameter and changes the default value to mirror the changes in diffusion/dislocation merged in #5338.