Fix check field type and typos #5606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you have a conflict, can you rebase and fix? Ignore the deal.II master tester for now, we have one unrelated test failing for that one. |
anne-glerum
force-pushed
the
fix_typos_Mar2024
branch
from
f321926
to
0bfde32
Compare
gassmoeller
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5588 some code was introduced that doesn't compile. I didn't realize because the file in which the changes were made is only compiled if ASPECT links to FastScape. This PR does compile and I checked that the checks throw as expected when linked to FastScape.
This PR also fixes some typos and extens some doc strings about FastScape parameters.
For all pull requests:
For new features/models or changes of existing features: